Skip to content

Commit

Permalink
- harmonize the viewlet and browserpage allowed_interface declarations
Browse files Browse the repository at this point in the history
  • Loading branch information
dataflake committed Jan 26, 2020
1 parent 5bfcac7 commit a98a155
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
5.0a1 (unreleased)
------------------

- harmonize the viewlet and browserpage allowed_interface declarations
(`#755 <https://github.com/zopefoundation/Zope/issues/755>`_)

- Close opened db during shutdown (as ZServer is already doing).
(`#740 <https://github.com/zopefoundation/Zope/issues/740>`_)

Expand Down
4 changes: 2 additions & 2 deletions src/Products/Five/viewlet/metaconfigure.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def viewletManagerDirective(
allowed_attributes = ['render', 'update']
if allowed_interface is not None:
for interface in allowed_interface:
allowed_attributes.extend(interface.names())
allowed_attributes.extend(interface.names(all=True))

# Make sure that the template exists and that all low-level API methods
# have the right permission.
Expand Down Expand Up @@ -120,7 +120,7 @@ def viewletDirective(
allowed_attributes = ['render', 'update']
if allowed_interface is not None:
for interface in allowed_interface:
allowed_attributes.extend(interface.names())
allowed_attributes.extend(interface.names(all=True))

# Make sure that the template exists and that all low-level API methods
# have the right permission.
Expand Down

0 comments on commit a98a155

Please sign in to comment.