-
Notifications
You must be signed in to change notification settings - Fork 96
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Drop 'ZopeFieldStorage' in favor of 'cgi.FieldStorage'.
The stdlib bug which caused us to fork it is long gone, and we have our own Py3k bug now. Leave behind a BBB alias, in case anybody is expecting to import it.
- Loading branch information
Showing
1 changed file
with
3 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2f83e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit breaks a couple of Archetypes-Tests in Plone 5.2. See http://jenkins.plone.org/job/plone-5.2-python-2.7-at/143/
E.g. after processing a fileupload in plone.app.blob
request.form['file'].name
is the string<fdopen>
instead of a filepath (like/var/folders/n3/....
). This example is from http://jenkins.plone.org/job/plone-5.2-python-2.7-at/143/testReport/junit/plone.app.blob.tests.test_integration/IntegrationTests/testSize/e2f83e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the monkey patch in https://github.com/plone/plone.app.blob/blob/master/src/plone/app/blob/monkey.py#L56 doesn’t trigger anymore. The code in Zope is now instantiating the field storage as
cgi.FieldStorage
. The monkey patch only overwrites FieldStorage and ZopeFieldStorage.I think we could change the import back in Zope, so it directly does
from cgi import FieldStorage
. In that case the monkey patch should still work.e2f83e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hannosch Thanks. I did what you suggested in #235.
Also: In plone/Products.CMFPlone#2193 (comment) @mauritsvanrees suggested that the patch could go away altogether.
e2f83e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have merged the PR.