Username not in access log for error requests

[perrinjerome]

BUG/PROBLEM REPORT / FEATURE REQUEST

What I did:

Create a zope instance:

mkwsgiinstance -d username_log_repro  -u  admin:admin
runwsgi  ./username_log_repro/etc/zope.ini
# add a `standard_error_message` at root ( this is necessary for error requests to be logged at all in access log - this looks like another independent issue )
curl -d id=standard_error_message 'http://admin:admin@127.0.0.1:8080/manage_addProduct/OFSP/addDTMLMethod'

Make a successful HTTP request and see in the log that username (admin) appears

$ curl --silent -o /dev/null  http://admin:admin@127.0.0.1:8080 ; tail -n 1 username_log_repro/var/log/Z4.log
127.0.0.1 - admin [15/Sep/2023:16:13:03 +0200] "GET / HTTP/1.1" 200 2 "-" "curl/7.87.0"

Make an error HTTP request, the username field is empty:

$ curl --silent -o /dev/null  http://admin:admin@127.0.0.1:8080/error ; tail -n 1 username_log_repro/var/log/Z4.log
127.0.0.1 - - [15/Sep/2023:16:14:30 +0200] "GET /error HTTP/1.1" 404 229 "-" "curl/7.87.0"

What I expect to happen:

The username field should be present even for error requests.

What actually happened:

The username field is empty, for error requests. This is not only for "404 not found" requests, but also for server side errors.

What version of Python and Zope/Addons I am using:

This is on current master

---

I investigated and found that username is set in environ by

Zope/src/ZPublisher/WSGIPublisher.py

Lines 388 to 395 in 59f6870

	with load_app(module_info) as new_mod_info:
	with transaction_pubevents(request, response):
	response = _publish(request, new_mod_info)
	user = getSecurityManager().getUser()
	if user is not None and \
	user.getUserName() != 'Anonymous User':
	environ['REMOTE_USER'] = user.getUserName()

but this code is not executed if _publish gets an exception. I'm making a pull request.