New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore physical path in __repr__ of Zope objects #379

Closed
icemac opened this Issue Oct 18, 2018 · 2 comments

Comments

3 participants
@icemac
Member

icemac commented Oct 18, 2018

When using persistent < 4.4 the __repr__ of Zope objects contained the physical path of the object. Now it contains way more technical information about the OID and the connection. This breaks especially doctests and does not seem to be helpful in 80 % of the use cases where the physical path contains way more information than the OID.

Suggested solution:

  • Add a __repr__ method to OFS.SimpleItem to restore the physical path.

References:

@icemac icemac added this to the 4.0b7 milestone Oct 18, 2018

@icemac icemac added this to To do in Zope 4 final release via automation Oct 18, 2018

@pbauer pbauer referenced this issue Oct 18, 2018

Closed

Update to Zope 4.0b7 #2590

3 of 3 tasks complete

@icemac icemac moved this from To do to In progress in Zope 4 final release Oct 23, 2018

@icemac icemac closed this in #387 Oct 26, 2018

Zope 4 final release automation moved this from In progress to Done Oct 26, 2018

@pbauer

This comment has been minimized.

Contributor

pbauer commented Oct 27, 2018

With #392 I set _p_repr as suggested by @jamadden in plone/Products.CMFPlone#2590 (comment). With this we only need to add PathReprProvider to OFS.SimpleItem.Item. We might even move it to the end of the base-classes and no longer need to inherit from Base.

@pbauer pbauer reopened this Oct 27, 2018

Zope 4 final release automation moved this from Done to In progress Oct 27, 2018

@icemac

This comment has been minimized.

Member

icemac commented Oct 30, 2018

As #392 was not merged I am going to close this issue here again.

@icemac icemac closed this Oct 30, 2018

Zope 4 final release automation moved this from In progress to Done Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment