Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFS.Image.File.__str__ broken under Python 3 when data is a Pdata object #711

Closed
dataflake opened this issue Oct 8, 2019 · 0 comments

Comments

@dataflake
Copy link
Member

commented Oct 8, 2019

The __str__ implementation in OFS.Image.File is broken - Pdata objects do not have a decode method. It only works for files that are small enough so their data gets stored as a string value.

The issue exists on both master and the 4.x branch.

Zope/src/OFS/Image.py

Lines 665 to 666 in 5962a30

def __str__(self):
return self.data.decode(self._get_encoding())

@dataflake dataflake added the bug label Oct 8, 2019
@dataflake dataflake self-assigned this Oct 8, 2019
@dataflake dataflake added this to To do in Zope 4 bugfix via automation Oct 8, 2019
dataflake added a commit that referenced this issue Oct 9, 2019
@dataflake dataflake closed this in 46eeee3 Oct 9, 2019
Zope 4 bugfix automation moved this from To do to Done Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Zope 4 bugfix
  
Done
1 participant
You can’t perform that action at this time.