Fix several exceptions when calling ZPublisher.utils.fix_properties. #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created this function in Zope 5.4 and it worked for the databases I tried it on. But on another project I ran into several exceptions. See tracebacks in Plone: plone/plone.app.upgrade#270 Note that `plone.app.upgrade` has a temporary copy of the same function. I fixed the function there as well today: plone/plone.app.upgrade#271
icemac
approved these changes
Feb 3, 2022
dataflake
approved these changes
Feb 3, 2022
mauritsvanrees
deleted the
maurits-issue-270-improve-fix-unicode-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this function in Zope 5.4 and it worked for the databases I tried it on.
But on another project I ran into several exceptions.
See tracebacks in Plone:
plone/plone.app.upgrade#270
Note that
plone.app.upgradehas a temporary copy of the same function.I fixed the function there as well today:
plone/plone.app.upgrade#271