Python 3 support #113
Closed
Python 3 support #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need to convert the ast to source code before passing it to the RestrictedPython machinery. It takes the result of the 2.7 ast.parse() as well.
If pip installs AccessControl before RestrictedPyton, it will pick up the latest release instead of the other develop dependency.
This should not happen as we're dealing with parsed documents here and even if it happened, the solution is to not raise old-style class exceptions.
This actually uses the C extension under Py3.
…ble for ensuring the c implementation works the same way the python implementation does.
…emove the `unicode = str` workaround that is just wrong). This means some other tests might fail now that worked before, but those need better fixes anyway.
Turn them into failures.
|
We had a discussion at the current Zope sprint about what to do with the id attribute of persistent objects, which ends up both in the physical path as well as the URL. Our current thought is to make those native string, much like WSGI (PEP 3333) treats the HTTP headers. So the id will be of the |
Once those pass, we can run the tests for additional Products.
…ytes Pass bytes for file content.
…_encoding Juggle bytes / text for compressing copy-paste cookie.
|
I've merged in cleaned up version of this into master, further fixes can be done as PR's directly against master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39.