Fix subscript access on Page Template macros attribute
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataflake
changed the title
macros attributemacros attribute
hannosch
approved these changes
Feb 16, 2019
There was a problem hiding this comment.
Looking at the macros object (https://github.com/malthe/chameleon/blob/master/src/chameleon/zpt/template.py#L450), I think it's safe to expose it. There's not much that class can do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210
Under Zope 2.13, the
macrosattribute on a page template is a dictionary. The security machinery didn't care about it. With Chameleon, it is a real object.__allow_access_to_unprotected_subobjects__is a bit of a sledge hammer here, but I can't see any way of getting to such amacrosobject without hitting all necessary security checks before you even get close. Attempts to install aClassSecurityInfoon the class and declaring e.g.__getitem__public didn't work.