Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable registered error views for debugging in WSGI setups #563

Merged
merged 15 commits into from May 2, 2019

Conversation

dataflake
Copy link
Member

Fixes #562

Makes life much easier for developers, and enables us to use debugging and exception view tools that plug into the WSGI pipeline

@dataflake dataflake added this to the 4.0 final milestone Apr 26, 2019
@dataflake dataflake requested a review from icemac April 26, 2019 14:54
@dataflake dataflake self-assigned this Apr 26, 2019
@dataflake dataflake added this to In progress in Zope 4 final release via automation Apr 26, 2019
@d-maurer
Copy link
Contributor

There should be a way to disable the "reraise" even in debug mode: The "reraise" is useful only when you are using specialized tools; other features controlled by debug mode are useful in general. There should be no implicit coupling.

@dataflake dataflake changed the title Re-raise publishing exceptions when in debug mode Add setting to disable registered error views for debugging in WSGI setups Apr 27, 2019
@dataflake
Copy link
Member Author

The reraising is now done with a separate configuration setting.

@d-maurer
Copy link
Contributor

d-maurer commented Apr 27, 2019 via email

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. There are only some little suggestions.

CHANGES.rst Outdated Show resolved Hide resolved
src/ZPublisher/tests/test_WSGIPublisher.py Outdated Show resolved Hide resolved
docs/wsgi.rst Outdated Show resolved Hide resolved
Zope 4 final release automation moved this from In progress to Reviewer approved May 2, 2019
@dataflake dataflake merged commit 2139f2c into master May 2, 2019
Zope 4 final release automation moved this from Reviewer approved to Done May 2, 2019
@dataflake dataflake deleted the issue_562 branch May 2, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Make debugging under WSGI easier by allowing exceptions through
3 participants