-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove further tempstorage dependencies. #689
Conversation
@dataflake introduced both lines with Maybe it has to do with documenting the options? I am not very adept with RTD and Sphinx, so I have to pass on this review. P.S.: buildout finally works for Zope
I think this has nothing to do with this pull request, though. |
I would argue, that the failing build is actually the test here. It tells you that there is a requirement for a package that is installed, which is not version pinned -> thus the build fails. Adding a test that buildout builds fail if a package is used but not version pinned seems to me to be a redundant test of a buildout feature. |
@jugmac00 Do you have any Idea where in the docs it mentions tempstorage? I couldn't find anything, so it must be without using the actual name - but then again I don't really know the documentation. |
?rekcäH nitraM? wrote at 2019-8-18 22:41 -0700:
@jugmac00 Do you have any Idea where in the docs it mentions tempstorage? I couldn't find anything, so it must be without using the actual name - but then again I don't really know the documentation.
With Zope2, sessions have been avaialble automatically and used
`tempstorage` by default. Thus, there has been no need to document
`tempstorage` in entry level documentation. I recommend that experts directly
look at source level documentation (especially interfaces) and do not rely
on other documentation (which is often not complete and/or outdated).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing tempstorage
from the documentation requirements breaks the RTD build.
requirements-rtd.txt
Outdated
@@ -1,4 +1,3 @@ | |||
repoze.sphinx.autointerface | |||
Zope | |||
ZConfig==3.5.0 | |||
tempstorage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still required as long as the ZConfig schema contains the tempstorge
declaration.
See https://readthedocs.org/projects/zope/builds/9537827/ for the failed RTD build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
…e is removed from the config schema file.
This tries to fix #668 by removing further
tempstorage
dependencies.I am pretty sure that just removing
tempstorage
from the[docs]
section of extras require is pretty safe as I can't find any mention oftempstorage
in the documentation. I am a bit more hesitant about the requirements.rtd.txt - but am pretty sure that this is also not required.Feedback welcome.