New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rip out ZServer support. #696
Conversation
src/ZPublisher/Publish.py
Outdated
) | ||
|
||
# BBB Zope 5.0 | ||
# BBB Zope 6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this not ready for removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right it can be removed in 5.0 but in another PR.
Michael Howitz wrote at 2019-9-9 23:10 -0700:
...
-# BBB Zope 5.0
+# BBB Zope 6.0
You are right it can be removed in 5.0 but in another PR.
Please keep "webdav" support (which apparently accidentally
was moved into the `ZServer` package).
|
Zope 4 using WSGI does not support WebDAV. There is #649 track re-enabling it. It would be a huge benefit if Zope 5 could support WebDAV again. |
Michael Howitz wrote at 2019-9-10 23:19 -0700:
Zope 4 using WSGI does not support WebDAV. There is #649 track re-enabling it. It would be a huge benefit if Zope 5 could support WebDAV again.
I personally neither have the need nor resources to re-implement WebDAV in Zope, so any help is welcome.
"WebDAV" used to be a top level package in Zope 2.
I assume that it was put below `ZServer` under the (wrong) assumption
it were dependent on `ZServer`.
Could you move it into a separate "zopefoundation/webdav"?
`OFS` and (I think) `ZPublisher` have special handling for `WebDAV`.
It would be quite difficult (complex monkey patching) to have
`WebDAV` without this special code.
In Zope 4, this was dependent on `ZServer` and it therefore risks
to get lost with the outphasing of `ZServer`.
The dependency should become one of `WebDAV`.
|
I'm sure no one would complain if you just went ahead and did this yourself. 😉 |
Jens Vagelpohl wrote at 2019-9-11 03:12 -0700:
I'm sure no one would complain if you just went ahead and did this yourself. ?
I do not yet know how I can move parts from one git repository
(including its history) to a different or a new one.
|
There's a howto in the GitHub help pages: https://help.github.com/en/articles/splitting-a-subfolder-out-into-a-new-repository |
Hi @icemac , @dataflake , |
Zope |
@d-maurer I'd prefer to have Maybe only parts of 24d566b have to be reverted to get it back including its history. |
FYI: Instead of trying to fiddle with some git magic it is sufficient to simply copy the contents of the files in |
Michael Howitz wrote at 2019-9-11 23:17 -0700:
@d-maurer I'd prefer to have `webdav` back here in the Zope repository. I am not sure if it could be used standalone. As you said using it requires some changes in Zope which I do not want to have conditionally again.
I have no objections against `webdav` directly in the Zope repository.
|
Open questions/tasks:
ZApplicationWrapper.__bobo_traverse__
is actually only called by ZServer, seeZope/src/App/ZApplication.py
Lines 45 to 47 in b9a3469
fixes #592