Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out ZServer support. #696

Merged
merged 5 commits into from Sep 10, 2019
Merged

Rip out ZServer support. #696

merged 5 commits into from Sep 10, 2019

Conversation

icemac
Copy link
Member

@icemac icemac commented Sep 9, 2019

Open questions/tasks:

  • Should zserver directives be removed from etc/example.conf? ← they already have been removed
  • Find out if ZApplicationWrapper.__bobo_traverse__ is actually only called by ZServer, see
    def __bobo_traverse__(self, REQUEST=None, name=None):
    # This is only called by ZServer.ZPublisher.Publish,
    # as the app in the module_info is used directly.
    ← yes, it is actually used by a ZServer based Zope but not by a WSGI based one.

fixes #592

@icemac icemac self-assigned this Sep 9, 2019
@icemac icemac mentioned this pull request Sep 9, 2019
5 tasks
)

# BBB Zope 5.0
# BBB Zope 6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this not ready for removal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right it can be removed in 5.0 but in another PR.

@icemac icemac added this to the 5.0 milestone Sep 10, 2019
@icemac icemac added this to In progress in Zope 5.0 via automation Sep 10, 2019
@icemac icemac moved this from In progress to Reviewer approved in Zope 5.0 Sep 10, 2019
@icemac icemac merged commit 4aadecc into master Sep 10, 2019
@icemac icemac deleted the drop-zserver-support branch September 10, 2019 07:36
Zope 5.0 automation moved this from Reviewer approved to Done Sep 10, 2019
@d-maurer
Copy link
Contributor

d-maurer commented Sep 10, 2019 via email

@icemac
Copy link
Member Author

icemac commented Sep 11, 2019

Zope 4 using WSGI does not support WebDAV. There is #649 track re-enabling it. It would be a huge benefit if Zope 5 could support WebDAV again.
I personally neither have the need nor resources to re-implement WebDAV in Zope, so any help is welcome.

@icemac icemac mentioned this pull request Sep 11, 2019
@d-maurer
Copy link
Contributor

d-maurer commented Sep 11, 2019 via email

@dataflake
Copy link
Member

I'm sure no one would complain if you just went ahead and did this yourself. 😉

@d-maurer
Copy link
Contributor

d-maurer commented Sep 11, 2019 via email

@dataflake
Copy link
Member

There's a howto in the GitHub help pages: https://help.github.com/en/articles/splitting-a-subfolder-out-into-a-new-repository

@drfho
Copy link
Contributor

drfho commented Sep 11, 2019

Hi @icemac , @dataflake ,
today our Zope-latest testing system (working with Products.CMFCore) cannot start anymore, because some CMFCore-methods expect a variable OFS.bbb.HAS_ZSERVER.
This comaptibility problem can quickly be solved by providing a reduced module OFS.bbb just for setting the variable:
bbb_py.txt
HAS_ZSERVER = False
Or do you prefer fixing Products.CMFCore?

@dataflake
Copy link
Member

Zope master is the precursor of Zope 5. Since this is a major release backwards incompatibilities are OK. A lot of the removed code had already been emitting DeprecationWarnings so it is up to the packages that want to use the deprecated code to get fixed. Fix CMFCore.

@icemac
Copy link
Member Author

icemac commented Sep 12, 2019

@d-maurer I'd prefer to have webdav back here in the Zope repository. I am not sure if it could be used standalone. As you said using it requires some changes in Zope which I do not want to have conditionally again.

Maybe only parts of 24d566b have to be reverted to get it back including its history.

@dataflake
Copy link
Member

FYI: Instead of trying to fiddle with some git magic it is sufficient to simply copy the contents of the files in src/webdav from that commit diff (or in case they were updated in ZServer, from there) back into their old location. When you do a git add their history will be right back.

@d-maurer
Copy link
Contributor

d-maurer commented Sep 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Zope 5.0
  
Done
Development

Successfully merging this pull request may close these issues.

Remove ZServer support
4 participants