Fix unrestrictedTraverse not handling unicode strings #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... under Python 2. This closes #715. modified: CHANGES.rst modified: src/OFS/Traversable.py modified: src/OFS/tests/testTraverse.py
dataflake
requested changes
Oct 26, 2019
There was a problem hiding this comment.
Your patch breaks the expected semantics that I am reading out of the discussion on #674. The incoming path should be a native string. You're now allowing unicode strings under Python 2, which are not native strings under Python 2. I would also consider your issue #715 ad invalid because you're asking for something that was explicitly not supported, see the comment inside unrestrictedTraverse.
I would close, this PR, close #715 as invalid and change your own code. Check the strings you get back from the call to getDatabaseNames and convert them to native strings before using them in the call to unrestrictredTraverse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... under Python 2.
This closes #715.
modified: CHANGES.rst
modified: src/OFS/Traversable.py
modified: src/OFS/tests/testTraverse.py