Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkout of RestrictedPython. #814

Merged
merged 2 commits into from Jun 30, 2020
Merged

Use checkout of RestrictedPython. #814

merged 2 commits into from Jun 30, 2020

Conversation

icemac
Copy link
Member

@icemac icemac commented Apr 3, 2020

This hopefully fixed Python 3.9.

This hopefully fixed Python 3.9.
@icemac icemac added this to the 5.0 milestone Apr 3, 2020
@icemac icemac self-assigned this Apr 3, 2020
@icemac icemac added this to In progress in Zope 5.0 via automation Apr 3, 2020
@icemac icemac added this to In progress in Zope 5 via automation Apr 3, 2020
@icemac
Copy link
Member Author

icemac commented Apr 3, 2020

Python 3.9 still fails in some template tests. I cannot run the tests on Python 3.9 locally even though I have 3.9.0a5 installed: When calling tox -epy39 I get lots of errors that the Zope distribution cannot be found. I end up with over 100 test failures instead of the 6 ones TravisCI finds.

Does anyone have an idea to fix this locally without enforcing #791?

@dataflake
Copy link
Member

I see no such issues in my local setup. tox -epy39 ran as expected and produced the same failures you see on Travis.

@icemac
Copy link
Member Author

icemac commented Apr 3, 2020

I found a way to fix my local issue: Run bin/tox -epy39 after installing virtualenv in the local venv. Now I get the same errors as TravisCI. I'll try to look into this issue later.

@dataflake
Copy link
Member

Just did a cross-check with a fresh clone and everything is fine, apart from those six failures. This is how I create my sandbox:

git clone ...
cd Zope
python3.7 -m venv .
bin/pip install -U pip setuptools zc.buildout virtualenv wheel
bin/buildout
bin/tox

@icemac
Copy link
Member Author

icemac commented Apr 3, 2020

@dataflake My setup is quite close to yours. Thank you.

@icemac icemac marked this pull request as ready for review June 30, 2020 06:14
@icemac
Copy link
Member Author

icemac commented Jun 30, 2020

I'd like to merge this PR so the tests on Python 3.9 can get green. (With this PR they fail with AssertionError: Template errors: ['Compilation failed', 'builtins.SyntaxError: invalid syntax in a single test.)

As Zope 5 final ist to be released before the final Python 3.9 release (September vs. October 2020), I see no need to have a release of RestrictedPython supporting Python 3.9 before the Zope 5 release.

@dataflake dataflake self-requested a review June 30, 2020 06:24
Zope 5.0 automation moved this from In progress to Reviewer approved Jun 30, 2020
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zope 5 automation moved this from In progress to Reviewer approved Jun 30, 2020
@icemac icemac merged commit 0045361 into master Jun 30, 2020
Zope 5.0 automation moved this from Reviewer approved to Done Jun 30, 2020
Zope 5 automation moved this from Reviewer approved to Done Jun 30, 2020
@icemac icemac deleted the RestrictedPython-alpha branch June 30, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Zope 5
  
Done
Zope 5.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants