Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the management bar with the current version #843

Closed
wants to merge 1 commit into from
Closed

Update the management bar with the current version #843

wants to merge 1 commit into from

Conversation

rbanffy
Copy link

@rbanffy rbanffy commented Jun 4, 2020

It looks more appropriate. Maybe we could read the version on rendering, but it's not that terrible to edit this on every major release.

I'm just happy my favorite application server aged so well.

image

@dataflake dataflake self-assigned this Jun 4, 2020
@dataflake
Copy link
Member

How about the actual full version number instead?

@rbanffy
Copy link
Author

rbanffy commented Jun 4, 2020

I think the full version number would be too much information for a management interface. Would be a good idea for development branches, perhaps.

I also like that this patch is a single least-significant bit flip on a single character. It's the minimum possible commit that actually improves a product.

BTW, it's a bit puzzling that the test coverage decreased after changing one bit on a text file... 🤷‍♂️

@dataflake
Copy link
Member

I have created #844 which does the same thing without resorting to a hardcoded value.

@rbanffy
Copy link
Author

rbanffy commented Jun 4, 2020

Awww... That's too bad - yours is much better than mine. :-(

I guess I won't break my record for most insignificant open source contribution (currently another bit-flip, at http://bazaar.launchpad.net/~maas-committers/maas/trunk/revision/3825).

@dataflake
Copy link
Member

Don't feel bad - the idea was great and I uncovered a flaw in version parsing in Zope itself that I fixed at the same time.

@rbanffy
Copy link
Author

rbanffy commented Jun 4, 2020

Easy for you to say ;-)

Well... Let's close this. Yours is obviously a superior solution, even though mine was much more concise.

@rbanffy rbanffy closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants