Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use f-strings. #857

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Switch to use f-strings. #857

merged 2 commits into from
Jul 1, 2020

Conversation

icemac
Copy link
Member

@icemac icemac commented Jun 30, 2020

I called pyupgrade --py3-only --py3-plus --py36-plus --py37-plus on
the Python files.
While looking through the changes, I did some adoptions to sometimes
use f-strings in places where the tool did not use them.

Additionally pyupgrade removed some Python 2 compatiblity leftovers.

Fixes #841.

I called `pyupgrade --py3-only --py3-plus --py36-plus --py37-plus` on
the Python files.
While looking through the changes, I did some adoptions to sometimes
use f-strings in places where the tool did not use them.

Additionally `pyupgrade` removed some Python 2 compatiblity leftovers.
@icemac icemac added this to the 5.0 milestone Jun 30, 2020
@icemac icemac requested a review from dataflake June 30, 2020 08:12
@icemac icemac self-assigned this Jun 30, 2020
@icemac icemac added this to In progress in Zope 5.0 via automation Jun 30, 2020
Zope 5.0 automation moved this from In progress to Reviewer approved Jun 30, 2020
@icemac icemac merged commit 1b9f2c7 into master Jul 1, 2020
Zope 5.0 automation moved this from Reviewer approved to Done Jul 1, 2020
@icemac icemac deleted the issue-841/f-strings branch July 1, 2020 06:28
@jugmac00
Copy link
Member

jugmac00 commented Jul 7, 2020

@icemac

I called pyupgrade --py3-only --py3-plus --py36-plus --py37-plus on the Python files.

Does that mean Zope 5 does not support Python 3.6 any more?

@dataflake
Copy link
Member

No it doesn't. I am guessing that was either a typo or just done unintentionally. But either way, if you look at https://pypi.org/project/pyupgrade/ and search for any mention of --py37-plus then all you will find is something having to do with one kind of __future__ import.

@icemac
Copy link
Member Author

icemac commented Jul 8, 2020

I've never used generator_stop which is removed by --py37-plus and it is not in the diff. But you are right, I should not have used this option in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Zope 5.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants