Replace (in "OFS") deprecated direct "id" access by "getId" calls #907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct
id
access is deprecated (forOFS.SimpleItem.Item
instances). However, at some places (e.g. in export/import) it was still used inOFS
. This has caused #903 .The PR replaces most occurrences of direct
id
access by calls togetId
(provided the object has an unacquiredgetId
). The directid
accesses inOFS.Traversable.Traversable.getPhysicalPath
are retained (this might give wrong results for (likely rare) objects with bothid
and__name__
with diverging values).Fixes #903.