Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide friendlier ZMI error message for the Transaction Undo form #969

Merged
merged 3 commits into from
May 11, 2021
Merged

Provide friendlier ZMI error message for the Transaction Undo form #969

merged 3 commits into from
May 11, 2021

Conversation

dataflake
Copy link
Member

Fixes #964

@dataflake dataflake self-assigned this May 10, 2021
d-maurer
d-maurer approved these changes May 11, 2021
View reviewed changes
src/App/tests/test_ApplicationManager.py Outdated Show resolved Hide resolved
@dataflake dataflake merged commit 0ecd1ce into master May 11, 2021
@dataflake dataflake deleted the dataflake/issue_964 branch May 11, 2021 05:37
dataflake added a commit that referenced this pull request May 11, 2021
@dataflake
Provide friendlier ZMI error message for the Transaction Undo form (#969
e39cbc1 
)

* - Provide friendlier ZMI error message for the Transaction Undo form

* - enclosing test in try...finally to always ensure the cleanup runs

* - fix long line
@jugmac00
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-maurer d-maurer d-maurer approved these changes

@jugmac00 jugmac00 Awaiting requested review from jugmac00

Assignees

@dataflake dataflake

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undo a database transaction results in "internal server error" generated by waitress
3 participants
@dataflake @jugmac00 @d-maurer