Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to run the windows tests on GHA instead of AppVeyor. #975

Merged
merged 9 commits into from Jun 4, 2021

Conversation

icemac
Copy link
Member

@icemac icemac commented Jun 3, 2021

This PR is built on zopefoundation/meta#105.

@icemac icemac closed this Jun 3, 2021
@icemac icemac deleted the windows-ci-gha branch June 3, 2021 13:46
@icemac icemac restored the windows-ci-gha branch June 3, 2021 13:47
@icemac icemac reopened this Jun 3, 2021
@icemac
Copy link
Member Author

icemac commented Jun 3, 2021

Hm, how did the tests run successfully on AppVeyor? There are multiple problems with windows using \r\n instead of \n.

@icemac icemac marked this pull request as draft June 3, 2021 14:03
@icemac
Copy link
Member Author

icemac commented Jun 3, 2021

Okay, now just the tests have to be fixed on windows.

@icemac icemac marked this pull request as ready for review June 4, 2021 06:17
@icemac icemac requested a review from dataflake June 4, 2021 06:17
@icemac
Copy link
Member Author

icemac commented Jun 4, 2021

After approval I'd change the required CI jobs in the settings to the new names.

Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! 🎉

@icemac icemac merged commit 00094d5 into master Jun 4, 2021
@icemac icemac deleted the windows-ci-gha branch June 4, 2021 06:40
@icemac
Copy link
Member Author

icemac commented Jun 4, 2021

Thank you for reviewing this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants