Bugfix: when the Choice field value was invalid, dump used to crash.

zopefoundation · Oct 17, 2012 · 044add9 · 044add9
1 parent 3072550
commit 044add9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/cipher/configstore/configstore.py b/src/cipher/configstore/configstore.py
@@ -213,7 +213,10 @@ def dump_type_Choice(self, value, field):
         if value is None or value == '':
             return ''
         bound_field = field.bind(self.context)
-        return bound_field.vocabulary.getTerm(value).token
+        try:
+            return bound_field.vocabulary.getTerm(value).token
+        except LookupError:
+            return ''
 
     def dump_type_Tuple(self, value, field):
         return self.listValueSeparator.join(value) if value else ''

diff --git a/src/cipher/configstore/configstore.txt b/src/cipher/configstore/configstore.txt
@@ -412,6 +412,9 @@ Choice
   >>> store.load_type_Choice('', field) is None
   True
 
+  >>> store.dump_type_Choice(3, field)
+  ''
+
 List
 ~~~~