Make testsuite Python 2/3 compatible

[d-maurer]

• Handling of unicode literal string prefix in doctests

  • partly avoided by an explicit conversion to str (usually for ASCII values)
  • test partly replaced by a comparison with a unicode literal string (usually for non ASCII values)

• the "cgi" module of Python 3 and Python 2 behave differently for a two small "Content-Length" value
  Py 3: everything above this value is ignored; some data not processed
  Py 2: the value is ignored; all data processed
  To cope with this difference, the "http" function has been replaced by an auxiliary "http_request" function in some tests. "http_request" computes "Content-Length" correctly.

• the test framework (--> "http", "browser") expects different input types for Python 3 and Python 2
  Py 3: text
  Py 2: utf-8 encoded binary strings
  To cope with this difference, input values have been specified by explicit unicode literals (supported by both Python 3 and Python 2) and converted to the required type via an auxiliary "to_input" function.

[icemac]

Thank you for resolving this issue. I like your code changes.

Additionally the following files should be changed resp. added:

• setup.py – the trove classifiers (This package should support the same versions as Zope)
• travis.yml – so that the newly supported Python versions are tested, see z3c.wizard as an example how I would do it nowadays
• tox.ini – This file should be added to be able to run the tests locally against multiple Python versions see z3c.table as an example.
• .coveragerc – This file should be added to configure coverage see z3c.table

[sallner]

Thanks for the work you put into this project.

[d-maurer]

@icemac The Travis integration problems are likely caused by outdated versions of Persistence and RestrictedPython:

accesscontrol 4.0b6 has requirement Persistence>=3.0a3, but you'll have persistence 2.13.2 which is incompatible.
accesscontrol 4.0b6 has requirement RestrictedPython>=4.0a1, but you'll have restrictedpython 3.6.0 which is incompatible.
documenttemplate 3.0b5 has requirement RestrictedPython>=4.0a1, but you'll have restrictedpython 3.6.0 which is incompatible.

However, I have no idea how I can force the Travis environment to use the correct versions.

[icemac]

@d-maurer With these changes (see attached patch) locally Python 2.7 and 3.5 run successfully. (Newer Python versions fail with AttributeError: __index__ in ZPublisher/HTTPResponse:509

This most important point is the pip_pre = true which allows to install beta versions of the packages.

t.patch.txt

[icemac]

This hint should make it possible to run successfully on travis ci.

[d-maurer]

@icemac Thank you: with the --pre, at least the Python 2.7 tests have been successful. I will now add the other Python 3 tests again.

[icemac]

LGTM with some minor suggestions.

[icemac]

@d-maurer Thank you very much!

[icemac]

Released to PyPI: https://pypi.org/project/five.formlib/2.1/