Replace implements for implementer (#9)

* ignore coverage artefacts * Replace the use of `grok.implements()` with the `@grok.implementer()` directive throughout.
zopefoundation · Jan 17, 2018 · 6a063da · 6a063da
1 parent a03f0c2
commit 6a063da
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 12 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,8 +1,9 @@
-*.pyc
+__pycache__
 .coverage
+.coverage.*
 .installed.cfg
 .tox/
-__pycache__
+*.pyc
 bin
 develop-eggs
 htmlcov/

diff --git a/CHANGES.txt b/CHANGES.txt
@@ -4,8 +4,8 @@ Changes
 3.0.1 (unreleased)
 ------------------
 
-- Nothing changed yet.
-
+- Replace the use of `grok.implements()` with the `@grok.implementer()`
+  directive throughout.
 
 3.0.0 (2018-01-12)
 ------------------

diff --git a/src/grokcore/annotation/tests/annotation/annotation.py b/src/grokcore/annotation/tests/annotation/annotation.py
@@ -86,8 +86,8 @@ def addBrand(brand):
     def getBrands():
         """Return a list of brands."""
 
+@grok.implementer(IBranding)
 class Branding(grok.Annotation):
-    grok.implements(IBranding)
 
     def __init__(self):
         self._brands = OOTreeSet()

diff --git a/src/grokcore/annotation/tests/annotation/implementsmany.py b/src/grokcore/annotation/tests/annotation/implementsmany.py
@@ -21,5 +21,6 @@ class IOneInterface(interface.Interface):
 class IAnotherInterface(interface.Interface):
     pass
 
+@grok.implementer(IOneInterface, IAnotherInterface)
 class MammothAnnotations(grok.Annotation):
-    grok.implements(IOneInterface, IAnotherInterface)
+    pass
diff --git a/src/grokcore/annotation/tests/annotation/lazy.py b/src/grokcore/annotation/tests/annotation/lazy.py
@@ -117,8 +117,8 @@ class ILazy(interface.Interface):
         readonly=True)
 
 
+@grok.implementer(ILazy)
 class Lazy(grok.LazyAnnotation):
-    grok.implements(ILazy)
     grok.name('lazy.annotation.custom.name')
     grok.provides(ILazy)
 
@@ -141,8 +141,8 @@ class _IFauxLazy(interface.Interface):
     pass
 
 
+@grok.implementer(_IFauxLazy)
 class FauxLazy(grok.LazyAnnotation):
-    grok.implements(_IFauxLazy)
     grok.provides(_IFauxLazy)
 
     testing = grok.LazyAnnotationProperty(_FauxField(), 'testing')
@@ -153,8 +153,8 @@ class IIncorrect(interface.Interface):
     testing = schema.TextLine(title=u'testing')
 
 
+@grok.implementer(IIncorrect)
 class IncorrectAnnotation(grok.Annotation):
-    grok.implements(IIncorrect)
     grok.provides(IIncorrect)
 
     testing = grok.LazyAnnotationProperty(IIncorrect['testing'])
diff --git a/src/grokcore/annotation/tests/annotation/name.py b/src/grokcore/annotation/tests/annotation/name.py
@@ -52,10 +52,11 @@ class IImplicitName(interface.Interface):
     pass
 
 
+@grok.implementer(IExplicitName)
 class ExplicitName(grok.Annotation):
-    grok.implements(IExplicitName)
     grok.name('mammoth.branding')
 
 
+@grok.implementer(IImplicitName)
 class ImplicitName(grok.Annotation):
-    grok.implements(IImplicitName)
+    pass
diff --git a/src/grokcore/annotation/tests/annotation/provides.py b/src/grokcore/annotation/tests/annotation/provides.py
@@ -35,6 +35,6 @@ class IAnotherOne(interface.Interface):
     pass
 
 
+@grok.implementer(IOneInterface, IAnotherOne)
 class MammothAnnotation(grok.Annotation):
-    grok.implements(IOneInterface, IAnotherOne)
     grok.provides(IOneInterface)