Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building docs #44

Merged
merged 5 commits into from
Nov 23, 2020
Merged

Support building docs #44

merged 5 commits into from
Nov 23, 2020

Conversation

icemac
Copy link
Member

@icemac icemac commented Nov 20, 2020 •
edited
Loading

This sits on top of #43. The commits on this branch start with 58dbe25.
See the following examples built with this branch:

@icemac icemac requested a review from mgedmin November 20, 2020 15:43
@icemac icemac marked this pull request as draft November 20, 2020 16:28
@icemac icemac marked this pull request as ready for review November 20, 2020 16:31
mgedmin
mgedmin approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

and this is a great demonstration on why Jinja was a good idea, imagine doing this with %-formatting ;)

config/README.rst Outdated Show resolved Hide resolved
@icemac icemac merged commit 40875b0 into master Nov 23, 2020
@icemac icemac deleted the support-building-docs branch November 23, 2020 07:35
@icemac
Copy link
Member Author

icemac commented Nov 23, 2020

Thank you for reviewing this PR. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icemac @mgedmin