clean up refcounting around INTERN_INPLACE

zopefoundation · Mar 30, 2015 · 62543ae · 62543ae
1 parent 7bd85c1
commit 62543ae
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/persistent/cPersistence.c b/persistent/cPersistence.c
@@ -559,14 +559,13 @@ pickle___setstate__(PyObject *self, PyObject *state)
         while (PyDict_Next(state, &i, &d_key, &d_value)) {
             /* normally the keys for instance attributes are
                interned.  we should try to do that here. */
-            Py_INCREF(d_key);
-            if (NATIVE_CHECK_EXACT(d_key))
+            if (NATIVE_CHECK_EXACT(d_key)) {
+                Py_INCREF(d_key);
                 INTERN_INPLACE(&d_key);
-            if (PyObject_SetItem(*dict, d_key, d_value) < 0) {
                 Py_DECREF(d_key);
-                return NULL;
             }
-            Py_DECREF(d_key);
+            if (PyObject_SetItem(*dict, d_key, d_value) < 0)
+                return NULL;
         }
     }