Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude the 'terryfy' directory from wheels and sdists #100

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Exclude the 'terryfy' directory from wheels and sdists #100

merged 1 commit into from
Oct 22, 2018

Conversation

jamadden
Copy link
Member

Fixes #99

bdist_wheel isn't guided by the MANIFEST, only sdists are. So we have to specify what packages to include in setup.py, which is what guides bdist_wheel.

mgedmin
mgedmin approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(Ideally I'd like a .travis.yml change to test that we're not getting terrify in sdists/bdists, but that can be nontrivial and is probably not worth the effort.)

@jamadden jamadden merged commit 3337ee6 into master Oct 22, 2018
@jamadden jamadden deleted the issue99 branch October 22, 2018 12:40
@jamadden jamadden mentioned this pull request Oct 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamadden @mgedmin