Fix some typos in docs. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR and especially the call out! The only usage I can find of a cache setting an object’s state is when it creates a new ghost. So perhaps uninitalized it should be. (Though I didn’t try to review all docs for correctness. ) |
|
So, should I fix it, or wait for more reviewers? |
|
I think you can fix it. |
|
@ramiroluz Is this pull request ready to merge or are you still working on it? |
|
Almost done, just need a quick fix, mentioned in the review. I can do it
tomorrow (Tuesday) night.
Em seg, 19 de nov de 2018 02:29, Michael Howitz <notifications@github.com
escreveu:
… @ramiroluz <https://github.com/ramiroluz> Is this pull request ready to
merge or are you still working on it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAR5NtaYl0JPAc6-3jVbGk5KjNbjim4vks5uwl3ngaJpZM4YYVEy>
.
|
|
@icemac done. |
|
I do not think that merging this PR requires to sign a contributor agreement so I am going to merge it. |
|
Thank you! |
|
Indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some typos in the docs.
REVIEWER: please pay attention to the cache.rst doc. On the first Note, I assumed that the author intended to say: "... newly created and initialized objects directly ... " instead of "... uninitialized ..."