Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terrif now supports py3.8 builds on mac #121

Merged
merged 1 commit into from Jan 16, 2020
Merged

terrif now supports py3.8 builds on mac #121

merged 1 commit into from Jan 16, 2020

Conversation

fgregg
Copy link
Contributor

@fgregg fgregg commented Jan 16, 2020

Terrify now supports building py3.8 on mac os.

Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The failures seem unrelated.

@mgedmin
Copy link
Member

mgedmin commented Jan 16, 2020

The failures appear to be nedbat/coveragepy#703.

@fgregg
Copy link
Contributor Author

fgregg commented Jan 16, 2020

should I merge?

Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be merged. Failure isn't a result of this.

@fgregg fgregg merged commit 98daec2 into master Jan 16, 2020
@mgedmin
Copy link
Member

mgedmin commented Jan 17, 2020

Python 3.6 build regression is now tracked (well, fixed, I was too lazy to create an issue so I created a PR) in #122

@mgedmin mgedmin deleted the travis_mac_py3.8 branch January 17, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants