Fix PersistentDict.update to accept keyword arguments. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #126. Also optimize clear and popitem to not mark the object as changed unnecessarily.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the native
UserDict. Previously, most uses of keyword arguments resulted inTypeError; in the undocumented and extremely unlikely event of a single keyword argument calledbthat happens to be a dictionary, the behaviour will change. Also adjustthe signatures of
setdefaultandpopto match the native version.Also optimize
clearandpopitemto not mark the object as changed unnecessarily.Fixes #126