Make the Python PickleCache run a GC when it evicts weakly-referenced objects. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A version of this fix is present in nti.testing where it was necessary to test persistent zope.component registries under PyPy. Are there any interested reviewers? |
icemac
reviewed
Apr 13, 2021
There was a problem hiding this comment.
I cannot judge the code, as I do not know enough about it.
I read the changes in the last commit and they look fine for me.
I tested locally by removing the gc.collect() call and it fails four tests on PyPy2 and PyPy3 but on CPython the call is not needed. That's fine as it was the goal of the PR.
… objects. This fixes hard-to-debug ZODB ConnectionStateError cases with persistent zope.component registrations on PyPy. I tried to come up with a test that would also fail on CPython using circular references, but did not succeed (because part of evicting objects is clearing their dict, breaking the reference cycle). Fixes #149
Co-authored-by: Michael Howitz <mh@gocept.com>
Thank you for reviewing, and thank you for testing. I plan to move ahead with merging and releasing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes hard-to-debug ZODB ConnectionStateError cases with persistent zope.component registrations on PyPy.
I tried to come up with a test that would also fail on CPython using circular references, but did not succeed (because part of evicting objects is clearing their dict, breaking the reference cycle).
Fixes #149. Well, band-aids it anyway. I'd like to think of a better way (the assumption that weakrefs are cleared immediately is pretty baked-in to zope.interface, at least when used with ZODB).
Currently based on #161 to avoid conflicts; only the last commit is relevant.