Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.11 (as of 3.11a6). #170

Merged
merged 1 commit into from Mar 10, 2022
Merged

Add support for Python 3.11 (as of 3.11a6). #170

merged 1 commit into from Mar 10, 2022

Conversation

icemac
Copy link
Member

@icemac icemac commented Mar 9, 2022

No description provided.

@icemac icemac requested review from jamadden and d-maurer March 9, 2022 08:04
jamadden
jamadden approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except I don't see a classifier added to setup.py for 3.11. Are we holding off for 3.11 final to do that?

@icemac
Copy link
Member Author

icemac commented Mar 9, 2022

LGTM, except I don't see a classifier added to setup.py for 3.11. Are we holding off for 3.11 final to do that?

Until the final release of a Python version we neither list it in the trove classifiers nor create wheels for it as we are not able to guarantee that the release will also work with the final version. The update is mostly to test Python 3.11 compatibility in packages depending on this one.

@icemac icemac merged commit b9435c3 into master Mar 10, 2022
@icemac icemac deleted the config-with-c-code branch March 10, 2022 06:51
@icemac
Copy link
Member Author

icemac commented Mar 10, 2022

Thank you for reviewing this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamadden jamadden jamadden approved these changes

@d-maurer d-maurer d-maurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icemac @jamadden @d-maurer