Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.7 and drop 3.3 #74

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Add support for Python 3.7 and drop 3.3 #74

merged 2 commits into from
Jul 31, 2018

Conversation

jamadden
Copy link
Member

ZODB, BTrees, and zope.container all have already dropped 3.3

Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(I wish this was merged before the 4.3.0 release, oh well...)

@@ -8,7 +8,8 @@ for PYBIN in /opt/python/*/bin; do
[[ "${PYBIN}" == *"cp33"* ]] || \
[[ "${PYBIN}" == *"cp34"* ]] || \
[[ "${PYBIN}" == *"cp35"* ]] || \
[[ "${PYBIN}" == *"cp36"* ]]; then
[[ "${PYBIN}" == *"cp36"* ]] || \
[[ "${PYBIN}" == *"cp37"* ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I wonder if *cp3[3-7]* would work as well, but I'm not a bash expert.)

@jamadden jamadden merged commit 681861b into master Jul 31, 2018
@jamadden jamadden deleted the py37 branch July 31, 2018 14:45
jamadden added a commit that referenced this pull request Jul 31, 2018
Both are essentially deprecated.

This is a step in producing usable coverage numbers.

(Also remove cp33 from the manylinux build. This was missed in #74)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants