Skip to content

Commit

Permalink
remove definition of synchronizer methods again - as it reduced the t…
Browse files Browse the repository at this point in the history
…est coverage and is apparently not necessary if all tests pass
  • Loading branch information
d-maurer committed May 6, 2019
1 parent 2404dcd commit 56d028b
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions transaction/tests/test__manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -703,12 +703,16 @@ def run(self):
stopped.set()
runner.join(1)

# The lack of the method below caused a test failure in one run
# -- maybe caused indirectly by the failure of another test
# Defining the methods below reduced the "test coverage". We
# therefore remove them again
# the preceeding test (maybe others as well) registers `self` as
# synchronizer; satisfy the `ISynchronizer` requirements
def newTransaction(self, transaction):
pass
## def newTransaction(self, transaction):
## pass

beforeCompletion = afterCompletion = newTransaction
## beforeCompletion = afterCompletion = newTransaction


class TestThreadTransactionManager(unittest.TestCase):
Expand Down

0 comments on commit 56d028b

Please sign in to comment.