Skip to content

Commit

Permalink
try to increase test coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
d-maurer committed Jun 19, 2019
1 parent 5aef8c2 commit dff1c94
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
1 change: 0 additions & 1 deletion transaction/_transaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ def __init__(self, synchronizers=None, manager=None):
# List of (hook, args, kws) tuples added by addAfterCommitHook().
self._after_commit = []


# List of (hook, args, kws) tuples added by addBeforeAbortHook().
self._before_abort = []

Expand Down
23 changes: 23 additions & 0 deletions transaction/tests/test__transaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -1082,6 +1082,29 @@ def _hook2(*args, **kw):
self.assertTrue(logger._log[0][1].startswith(
"Error in abort() on manager"))

def test_callAfterAbortHook_w_error_w_abort_error(self):
from transaction.tests.common import DummyLogger
from transaction.tests.common import Monkey
from transaction import _transaction
_hooked2 = []
def _hook1(*args, **kw):
raise ValueError()
def _hook2(*args, **kw):
_hooked2.append((args, kw))
logger = DummyLogger()
with Monkey(_transaction, _LOGGER=logger):
txn = self._makeOne()
logger._clear()
r = Resource("r", "abort")
txn.join(r)
txn.addAfterAbortHook(_hook1, ('one',), dict(dos=1))
txn.addAfterAbortHook(_hook2, ('two',), dict(dos=2))
with self.assertRaises(ValueError):
txn._callAfterAbortHooks()
self.assertEqual(logger._log[0][0], 'error')
self.assertTrue(logger._log[0][1].startswith(
"Error in abort() on manager"))

def test_abort_w_abortHooks(self):
comm = []
txn = self._makeOne()
Expand Down

0 comments on commit dff1c94

Please sign in to comment.