Add support for Python 3.7. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgedmin
approved these changes
Oct 16, 2018
There was a problem hiding this comment.
LGTM, except for the framework classifier change.
(If we want to deprecate one classifier and switch to another, I think it would be best to do a mass commit to all 209 affected repos. I'd be happy to volunteer for that part, given justification for the change. The annoying bit would be making 209 releases and I have no plans for volunteering for that part. ;-)
| 'Programming Language :: Python :: Implementation :: CPython', | ||
| 'Programming Language :: Python :: Implementation :: PyPy', | ||
| 'Natural Language :: English', | ||
| 'Operating System :: OS Independent', | ||
| 'Topic :: Internet :: WWW/HTTP', | ||
| 'Framework :: Zope3'], | ||
| url='http://pypi.python.org/pypi/z3c.authviewlet', | ||
| 'Framework :: Zope :: 3'], |
There was a problem hiding this comment.
We have "Framework :: Zope3" in 209 zopefoundation packages.
We have "Framework :: Zope :: 3" in 3 packages (z3c.checkversions, zodbupdate and zope.fanstatic).
I think we should stick with the more popular classifier.
There was a problem hiding this comment.
The more popular classifier is the older one which I am going to declare as deprecated. (To get a Trove classifier for Zope 4 we had to switch to the new schema.) My plan is to migrate all usages of the old classifier to the new format. My idea was to do this every time I see an old classifier.
I do not have checkouts for all 209 repositories so I would appreciate it very much if you could
help with a mass commit to make the migration faster. I do not think that we will need releases right now. For me it is enough that the packages will be released eventually when it is needed for a feature or bugfix.
There was a problem hiding this comment.
Fair enough!
I wrote ghcloneall so I could get checkouts of all 380 zopefoundation's repos. Given that it's easy to run a shell loop that changes setup.py files with sed and git pushes.
There was a problem hiding this comment.
I would like some meta-repository where we could track cross-repo issues like this. https://github.com/zopefoundation/zopefoundation/issues maybe?
There was a problem hiding this comment.
Good idea. I decided for meta as project name, so there is now zopefoundation/meta#1.
mgedmin
added a commit
to zopefoundation/cipher.background
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/cipher.configstore
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/cipher.lazydate
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/cipher.longrequest
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/cipher.session
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grok
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.annotation
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.catalog
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.chameleon
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.content
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.error
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.errorview
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.formlib
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.json
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.layout
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.message
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.permission
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.registries
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.rest
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.site
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.startup
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.traverser
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.view
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.viewlet
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/grokcore.xmlrpc
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.principalannotation
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.principalregistry
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.processlifetime
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.proxy
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.ptresource
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.renderer
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.schema
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.schemaevent
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.security
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.securitypolicy
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.sendmail
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.sequencesort
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.server
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.session
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.site
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.sqlalchemy
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.tal
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.tales
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.testing
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.testrunner
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.untrustedpython
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.viewlet
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.vocabularyregistry
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
mgedmin
added a commit
to zopefoundation/zope.wfmc
that referenced
this pull request
Oct 18, 2018
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
|
@mgedmin Thanks a lot. It is good to see that we have to fix many projects to support current releases of zope.schema, zope.configuration resp. persistent. |
yangkun315r
added a commit
to yangkun315r/zopefoundation
that referenced
this pull request
Jan 23, 2022
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
BZPhahar
added a commit
to BZPhahar/zopefoundation
that referenced
this pull request
Jan 23, 2022
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
asia040g
added a commit
to asia040g/zopefoundation
that referenced
this pull request
Jan 23, 2022
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
asia040g
added a commit
to asia040g/zopefoundationv
that referenced
this pull request
Jan 23, 2022
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
asia040g
added a commit
to asia040g/zopefoundationm
that referenced
this pull request
Jan 23, 2022
See zopefoundation/z3c.authviewlet#6 (comment) for the background behind this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.