Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config with pure python #7

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Config with pure python #7

merged 2 commits into from
Apr 7, 2021

Conversation

icemac
Copy link
Member

@icemac icemac commented Mar 30, 2021

Lint the code.
Add support for Python 3.8 and 3.9.
Make tests compatible with zope.component >= 5.

Michael Howitz added 2 commits March 30, 2021 08:42
Configuring for pure-python
1f3b08c
Lint the code.
586b858 
Add support for Python 3.8 and 3.9.
Make tests compatible with ``zope.component >= 5``.
@icemac icemac requested a review from jamadden March 30, 2021 06:45
mgedmin
mgedmin approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not scrutinize the diff too closely, but lgtm

jamadden
jamadden approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@icemac icemac merged commit befbc12 into master Apr 7, 2021
@icemac icemac deleted the config-with-pure-python branch April 7, 2021 06:27
@icemac
Copy link
Member Author

icemac commented Apr 7, 2021

Thank you for reviewing this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

@jamadden jamadden jamadden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icemac @mgedmin @jamadden