Skip to content

Commit

Permalink
Make it easier to see what package the 'was:' line refers to.
Browse files Browse the repository at this point in the history
  • Loading branch information
mgedmin committed Jun 11, 2012
1 parent 6a45c46 commit 25a7ac8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion z3c/checkversions/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def check(self, level=0):
if self.incremental == True:
self.incremental = 'stop'
if self.verbose:
print("# was: %s" % version)
print("# was: %s=%s" % (name, version))
print("%s=%s" % (name, new_dist.version))
elif self.verbose:
print("%s=%s" % (name, version))
Expand Down
18 changes: 9 additions & 9 deletions z3c/checkversions/buildout.txt
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ The verbose mode gives the current and previous versions
>>> checker = buildout.Checker(filename=buildout_path, verbose=True)
>>> checker.check(level=2)
# Checking buildout file ...
# was: 3.0.0
# was: zope.component=3.0.0
zope.component=3.0.3
# was: 3.4.0
# was: zope.interface=3.4.0
zope.interface=3.4.1

The old comments are removed:
Expand All @@ -70,17 +70,17 @@ The old comments are removed:
... index = %s
... versions = versions
... [versions]
... # was: 3.4.0
... # was: zope.interface=3.4.0
... zope.interface = 3.4.1
... zope.component = 3.0.3
... """ % testindex)

>>> checker = buildout.Checker(filename=buildout_path, verbose=True)
>>> checker.check()
# Checking buildout file ...
# was: 3.0.3
# was: zope.component=3.0.3
zope.component=3.9.4
# was: 3.4.1
# was: zope.interface=3.4.1
zope.interface=3.6.1

We can provide a blacklist file, containing versions to not suggest.
Expand All @@ -95,9 +95,9 @@ This file may come from a buildbot remembering failures.
... blacklist=blacklist_path)
>>> checker.check()
# Checking buildout file ...
# was: 3.0.3
# was: zope.component=3.0.3
zope.component=3.9.2
# was: 3.4.1
# was: zope.interface=3.4.1
zope.interface=3.6.1

We can let the checker to suggest only one new package. This should be used to
Expand All @@ -109,7 +109,7 @@ test a just single new package against a set of other packages.
... blacklist=blacklist_path)
>>> checker.check()
# Checking buildout file ...
# was: 3.0.3
# was: zope.component=3.0.3
zope.component=3.9.2
zope.interface=3.4.1

Expand Down Expand Up @@ -153,7 +153,7 @@ pinned.
>>> checker.check()
# Checking buildout file ...
distribute=
# was: 3.0.0
# was: zope.component=3.0.0
zope.component=3.9.4

>>> os.remove(buildout_path)

0 comments on commit 25a7ac8

Please sign in to comment.