Silence unclosed file warning

zopefoundation · Sep 14, 2014 · 300a1c9 · 300a1c9
1 parent ea564e5
commit 300a1c9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/z3c/checkversions/base.py b/src/z3c/checkversions/base.py
@@ -47,8 +47,12 @@ def __init__(self,
         self.incremental = incremental
         if blacklist:
             # create a set of tuples with bad versions
-            self.blacklist = set([tuple(map(lambda x: x.strip(), line.split('=')))
-                        for line in open(blacklist).readlines() if '=' in line])
+            with open(blacklist) as b:
+                self.blacklist = set([
+                    tuple(map(lambda x: x.strip(), line.split('=')))
+                    for line in b.readlines()
+                    if '=' in line
+                ])
         else:
             self.blacklist = set()
         self.pi = package_index.PackageIndex(search_path=())