Fix compatibility with setuptools 39. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgedmin
approved these changes
Apr 23, 2018
| @@ -16,14 +16,10 @@ | |||
| from setuptools import package_index | |||
|
|
|||
|
|
|||
| _final_parts = '*final-', '*final' | |||
| def _final_version(parsed_version): | |||
| """Function copied from zc.buildout.easy_install._final_version | |||
There was a problem hiding this comment.
Is the docstring still accurate now that you've replaced the implementation?
There was a problem hiding this comment.
Yes it is, I copied the implementation from the current version of zc.buildout.
| trunked_candidate = [x for x in dist.parsed_version[:level] | ||
| if not x.startswith('*')] | ||
| trunked_current = parsed_version.base_version.split('.')[:level] | ||
| trunked_candidate = dist.parsed_version.base_version.split('.')[:level] |
There was a problem hiding this comment.
The comment needs some updating -- the "remove *final" bit is no longer true.
|
Let's drop Python 2.6 from travis (and tox and setup.py and mention that in the changelog). (We should also add 3.5 and 3.6 to travis and tox and setup.py and changelog.) |
|
@mgedmin I dropped 2.6 and 3.3. |
|
@mgedmin Could you create a release on PyPI or give me ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8.