Bug: FileDataGenerator used the full filename to generate the random …

…seed.
zopefoundation · Apr 7, 2014 · 41f3904 · 41f3904
1 parent 4b4b323
commit 41f3904
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -5,7 +5,8 @@ CHANGES
 2.1.1 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Bug: FileDataGenerator used the full filename to generate the random seed.
+  That is definitely going to break consistency/tests on someone else's system.
 
 
 2.1.0 (2013-03-15)

diff --git a/src/z3c/datagenerator/generator.py b/src/z3c/datagenerator/generator.py
@@ -24,6 +24,7 @@
 
 from z3c.datagenerator import interfaces
 
+
 def consistent_hash(buf):
     # Produce a hash of a string that behaves consistently in Python 32 and
     # 64 bit.  The "& 0xffffffff" interprets negative numbers as positive.
@@ -55,7 +56,8 @@ class FileDataGenerator(object):
     path = os.path.dirname(__file__)
 
     def __init__(self, seed, filename):
-        self.random = random.Random(consistent_hash(seed+filename))
+        justname = os.path.basename(filename)
+        self.random = random.Random(consistent_hash(seed+justname))
         self.values = self._read(filename)
 
     def get(self):