Merge branch 'tdesvenain-master', from git://github.com/tdesvenain/z3…

…c.form.git

CHANGES.txt

@@ -6,7 +6,9 @@ CHANGES
 ------------------
 
 - Add DataExtractedEvent, which is thrown after data and errors are extracted
-  from widgets. Fixes https://github.com/zopefoundation/z3c.form/pull/18 
+  from widgets. Fixes https://github.com/zopefoundation/z3c.form/pull/18
+
+- Remove spaces at start and end of text field values.
 
 - Explicitly hide span in ``orderedselect_input.pt``.  This only
   contains hidden inputs, but Internet Explorer 10 was showing them

src/z3c/form/converter.py

@@ -31,6 +31,8 @@
 @zope.interface.implementer(interfaces.IDataConverter)
 class BaseDataConverter(object):
     """A base implementation of the data converter."""
+
+    _strip_value = True # Remove spaces at start and end of text line
 
     def __init__(self, field, widget):
         self.field = field
@@ -44,6 +46,8 @@ def toWidgetValue(self, value):
 
     def toFieldValue(self, value):
         """See interfaces.IDataConverter"""
+        if self._strip_value and isinstance(value, basestring):
+            value = value.strip()
         if value == u'':
             return self.field.missing_value
         return self.field.fromUnicode(value)

src/z3c/form/converter.txt

@@ -241,6 +241,19 @@ Again, the error message, is customized to the floating point:
       (u'The entered value is not a valid decimal literal.', u'fff')
 
 
+Text Data Converters
+----------------------
+
+Users often add empty spaces by mistake, for example when copy-pasting content
+into the form.
+
+  >>> name = zope.schema.TextLine()
+  >>> namewidget = widget.Widget(TestRequest())
+  >>> conv = converter.FieldDataConverter(name, namewidget)
+  >>> conv.toFieldValue(u'Einstein ')
+  'Einstein'
+
+
 Date Data Converter
 -------------------
 

src/z3c/form/subform.txt

@@ -363,7 +363,7 @@ Let's now have a look at cases where an error happens. If an error occurs in
 the parent form, the sub-form is still submitted:
 
   >>> request = TestRequest(form={
-  ...     'car.widgets.model': u'Volvo\n',
+  ...     'car.widgets.model': u'Volvo\n~',
   ...     'car.widgets.make': u'450',
   ...     'car.buttons.apply': u'Apply',
   ...     'owner.widgets.name': u'Stephan Richter',
@@ -400,7 +400,7 @@ Let's look at the rendered form:
           <input type="text" id="car-widgets-model"
                  name="car.widgets.model"
                  class="text-widget required textline-field"
-                 value="Volvo " />
+                 value="Volvo ~" />
         </div>
         <div class="row">
           <label for="car-widgets-make">Make</label>