Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to lxml > 4.7 #108

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Update tests to lxml > 4.7 #108

merged 1 commit into from
Jan 18, 2022

Conversation

icemac
Copy link
Member

@icemac icemac commented Dec 20, 2021 •
edited
Loading

Requiring at least that version.

Fixes #107.

@icemac icemac requested a review from agroszer December 20, 2021 08:27
@icemac icemac self-assigned this Dec 20, 2021
jamadden
jamadden reviewed Dec 20, 2021
View reviewed changes
Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's just differences in pretty-printing, right?

Because:

  1. The pin is only for tests;
  2. The pin doesn't drop any supported versions;
  3. The pin actually brings in a number of important CVE security fixes

I'm totally fine with updating the pin.

src/z3c/form/form.rst Show resolved Hide resolved
@icemac icemac merged commit f9c5f4e into master Jan 18, 2022
@icemac icemac deleted the re-107/fix-lxml-4.7 branch January 18, 2022 07:32
@icemac
Copy link
Member Author

icemac commented Jan 18, 2022

Thank you for looking into this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamadden jamadden jamadden left review comments

@agroszer agroszer Awaiting requested review from agroszer

Assignees

@icemac icemac

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests break with lxml >= 4.7
2 participants
@icemac @jamadden