Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an edge case when field missing_value is not None #87

Merged
merged 1 commit into from Mar 4, 2019
Merged

Fix an edge case when field missing_value is not None #87

merged 1 commit into from Mar 4, 2019

Conversation

agroszer
Copy link
Contributor

@agroszer agroszer commented Mar 1, 2019

but a custom value that works as None.

icemac
icemac approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, I have only some little suggestions.

src/z3c/form/tests/test_bugfix.py Outdated Show resolved Hide resolved
src/z3c/form/tests/test_bugfix.py Outdated Show resolved Hide resolved
@agroszer agroszer merged commit a76979d into master Mar 4, 2019
@icemac icemac deleted the adamg-fix-converter-is branch March 6, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agroszer @icemac