Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Update to Python 3. #1

Merged
merged 11 commits into from
Dec 21, 2018
Merged

Update to Python 3. #1

merged 11 commits into from
Dec 21, 2018

Conversation

icemac
Copy link
Member

@icemac icemac commented Dec 15, 2018

No description provided.

Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the weird classifiers.

setup.py Outdated
'Programming Language :: Python :: Implementation :: CPython',
'Programming Language :: Python :: Implementation',
'Programming Language :: Python',
'Programming Language :: Python',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two last lines look unintentional.

@mgedmin
Copy link
Member

mgedmin commented Dec 17, 2018

I've activated the repository on Travis.

@icemac
Copy link
Member Author

icemac commented Dec 18, 2018

I've activated the repository on Travis.

Interestingly the tests ran on travis-ci.com, see https://travis-ci.com/zopefoundation/z3c.preference

@mgedmin
Copy link
Member

mgedmin commented Dec 18, 2018

Oh, whoops! I saw "build: unknown" on the badge and didn't realize it was because of course it was talking about git master.

I wonder if Travis will now do builds on both .org and .com.

@icemac
Copy link
Member Author

icemac commented Dec 21, 2018

@mgedmin wrote:

I wonder if Travis will now do builds on both .org and .com.

Yes, it does. I am going to deactivate .org as .com seems to be the future.

@icemac icemac merged commit d1dc02f into master Dec 21, 2018
@icemac icemac deleted the update branch December 21, 2018 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants