Simplify subprocess cleanup.

zopefoundation · Apr 9, 2020 · 30309ca · 30309ca
1 parent 24bc033
commit 30309ca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/z3c/recipe/compattest/runner.py b/src/z3c/recipe/compattest/runner.py
@@ -53,10 +53,9 @@ def poll(self):
             self.exitcode = self.process.poll()
         if self.exitcode is not None and self.process is not None:
             self.end = time.time()
-            # We're done, get it all
-            data = self.process.stdout.read()
-            # Close the pipes and cleanup.
-            self.process.communicate()
+            # We're done, get all remaining output, and
+            # close the pipes.
+            data = self.process.communicate()[0]
             self.process = None
         else:
             # We're not done, so just get some

diff --git a/tox.ini b/tox.ini
@@ -18,7 +18,6 @@ setenv =
 [testenv:coverage]
 skip_install = true
 commands =
-    coverage erase
     coverage combine
     coverage html -i
     coverage xml -i