attr.getFileInfo() no longer crashes if the context element wasn't pa…

…rsed.
zopefoundation · Oct 23, 2017 · 2a7f86c · 2a7f86c
1 parent 5206896
commit 2a7f86c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -27,6 +27,8 @@ CHANGES
 
 - Support for Python 3.5 [Kyle MacFarlane]
 
+- attr.getFileInfo() crashed if the context element wasn't parsed.
+
 
 3.1.0 (2016-04-04)
 ------------------

diff --git a/src/z3c/rml/attr.py b/src/z3c/rml/attr.py
@@ -37,6 +37,10 @@ def getFileInfo(directive):
     root = directive
     while root.parent:
         root = root.parent
+    # Elements added through API won't have a sourceline
+    if directive.element.sourceline is None:
+        return '(file %s)' % (root.filename)
+
     return '(file %s, line %i)' % (
         root.filename, directive.element.sourceline)
 

diff --git a/src/z3c/rml/rml-reference.pdf b/src/z3c/rml/rml-reference.pdf
diff --git a/src/z3c/rml/tests/expected/rml-examples-032-images.pdf b/src/z3c/rml/tests/expected/rml-examples-032-images.pdf