Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with SQLAlchemy 2.0 #15

Closed
icemac opened this issue Jun 13, 2023 · 3 comments
Closed

Not compatible with SQLAlchemy 2.0 #15

icemac opened this issue Jun 13, 2023 · 3 comments

Comments

@icemac
Copy link
Member

icemac commented Jun 13, 2023

After the release of zope.sqlalchemy 3.0 the tests fail here, because zope.sqlalchemy now supports SQLAlchemy 2.0 but z3c.sqlalchemy does not.

See https://github.com/zopefoundation/z3c.sqlalchemy/actions/runs/5235300226/jobs/9452045557 for a failed test run. (But be advised: It's not just this import error, there are more errors below it. I tried to fix them and gave up as I know too little about the necessary changes to support SQLAlchemy 2.0.)

Meanwhile I declared SQLAlchemy < 2 on master: 69dd520 and created #14 with my changes.

CCing to possible users of this package (according to #13):

@dataflake @ale-rt

@dataflake
Copy link
Member

I have no sqlalchemy knowledge. I only did what I have to do to make Products.ZSSQLAlchemyDA work.

@ale-rt
Copy link
Member

ale-rt commented Jun 13, 2023

I can have a look

@ale-rt ale-rt self-assigned this Jun 13, 2023
ale-rt added a commit that referenced this issue Jun 30, 2023
ale-rt added a commit that referenced this issue Jun 30, 2023
@icemac icemac closed this as completed in fb7d533 Jul 4, 2023
@icemac
Copy link
Member Author

icemac commented Jul 5, 2023

Released the fix for this issue in https://pypi.org/project/z3c.sqlalchemy/2.1/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants