Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move interfaces to interfaces.py #9

Closed
jamadden opened this issue Nov 30, 2016 · 0 comments
Closed

Move interfaces to interfaces.py #9

jamadden opened this issue Nov 30, 2016 · 0 comments
Assignees
@jamadden
Labels
enhancement
Milestone
2.0

Comments

@jamadden
Copy link
Member

(But leave BWC imports in init.py.)

This follows the common standard and may also help with documentation.
@jamadden jamadden self-assigned this Nov 30, 2016
@jamadden jamadden added this to the 2.0 milestone Nov 30, 2016
jamadden added a commit that referenced this issue Dec 1, 2016
@jamadden
Add basic configuration block
732668f 
Currently in subscribers.py, this may or may not be the best
place for it. A substantial doc reorginazation can come after #8, #9 and
issue #6 (PR #10, this one) are merged.

[skip ci]
@jamadden jamadden mentioned this issue Dec 1, 2016
Merged
jamadden added a commit that referenced this issue Dec 3, 2016
@jamadden
Add subscribers for lifecycle events.
a60b78b 
There is a basic example of configuration, currently in subscribers.py,
this may or may not be the best place for it. A substantial doc
reorginazation can come after #8, #9 and issue #6 (PR #10, this one) are
merged.

Fixes #6
jamadden added a commit that referenced this issue Dec 7, 2016
@jamadden
Add subscribers for lifecycle events. (#10)
a4d5d01 
* Add subscribers for lifecycle events.

There is a basic example of configuration, currently in subscribers.py,
this may or may not be the best place for it. A substantial doc
reorginazation can come after #8, #9 and issue #6 (PR #10, this one) are
merged.

Fixes #6

* typos

* Refactor tests.

Separate each main functional test into its own file. This greatly
simplifies the imports of most of them.

Also simplify the subscriber tests by removing some partially duplicated
code.

* Correct wrong interface name in subscribers.zcml

Test this file by relying on it to configure the subscribers in
test_subscribers.py.
jamadden added a commit that referenced this issue Dec 7, 2016
@jamadden
Refactor interfaces and event implementation into interfaces.py
fc78987 
Fixes #9
@jamadden jamadden mentioned this issue Dec 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamadden jamadden

Labels
enhancement
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@jamadden