Lint the code.

Add support for Python 3.8 and 3.9.

CHANGES.txt

@@ -5,7 +5,7 @@ Changes
 1.2 (unreleased)
 ================
 
-- Nothing changed yet.
+- Add support for Python 3.8 and 3.9.
 
 
 1.1 (2018-11-07)

setup.py

@@ -22,6 +22,7 @@ def read_file(*args):
     with open(path, 'r') as f:
         return f.read() + '\n\n'
 
+
 setup(
     name='zc.sourcefactory',
     version='1.2.dev0',
@@ -56,6 +57,8 @@ def read_file(*args):
         'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
+        'Programming Language :: Python :: 3.8',
+        'Programming Language :: Python :: 3.9',
         'Programming Language :: Python :: Implementation :: CPython',
         'Natural Language :: English',
         'Operating System :: OS Independent',

src/zc/__init__.py

@@ -1,7 +1 @@
-# This directory is a Python namespace package.
-try:
-    import pkg_resources
-    pkg_resources.declare_namespace(__name__)
-except ImportError:
-    import pkgutil
-    __path__ = pkgutil.extend_path(__path__, __name__)
+__import__('pkg_resources').declare_namespace(__name__)  # pragma: no cover

src/zc/sourcefactory/adapters.py

@@ -20,6 +20,7 @@
 import zope.component
 import zc.sourcefactory.source
 
+
 @zope.interface.implementer(zope.schema.interfaces.ISourceQueriables)
 @zope.component.adapter(zc.sourcefactory.source.FactoredSource)
 def getSourceQueriables(factored_source):

src/zc/sourcefactory/basic.py

@@ -22,6 +22,7 @@
 import zc.sourcefactory.factories
 import zc.sourcefactory.policies
 
+
 class BasicSourceFactory(zc.sourcefactory.factories.BasicSourceFactory,
                          zc.sourcefactory.policies.BasicSourcePolicy):
     """Basic source factory implementation including a factory and the

src/zc/sourcefactory/browser/mapping.py

@@ -24,12 +24,12 @@
 
 @zope.interface.implementer(zope.browser.interfaces.ITerms)
 class MappedTerms(object):
-    """A terms implementation that knows how to handle a source that was 
+    """A terms implementation that knows how to handle a source that was
     created through a source factory.
     """
 
     zope.component.adapts(zc.sourcefactory.mapping.ValueMappingSource,
-        zope.publisher.interfaces.browser.IBrowserRequest)
+                          zope.publisher.interfaces.browser.IBrowserRequest)
 
     def __init__(self, source, request):
         self.base = zope.component.getMultiAdapter(

src/zc/sourcefactory/browser/tests.py

@@ -18,12 +18,13 @@
 
 from zc.sourcefactory.tests import setUp, tearDown, checker
 
+
 def test_suite():
     return unittest.TestSuite((
-            doctest.DocFileSuite(
-                'token.txt', setUp=setUp, tearDown=tearDown,
-                checker=checker, optionflags=doctest.ELLIPSIS),
-            doctest.DocFileSuite(
-                'README.txt', setUp=setUp, tearDown=tearDown,
-                checker=checker, optionflags=doctest.ELLIPSIS),
-            ))
+        doctest.DocFileSuite(
+            'token.txt', setUp=setUp, tearDown=tearDown,
+            checker=checker, optionflags=doctest.ELLIPSIS),
+        doctest.DocFileSuite(
+            'README.txt', setUp=setUp, tearDown=tearDown,
+            checker=checker, optionflags=doctest.ELLIPSIS),
+    ))

src/zc/sourcefactory/browser/token.py

@@ -34,6 +34,7 @@
 
 PY3 = sys.version_info[0] == 3
 
+
 @zope.component.adapter(bytes)
 @zope.interface.implementer(zc.sourcefactory.interfaces.IToken)
 def fromString(value):

src/zc/sourcefactory/contextual.py

@@ -22,6 +22,6 @@
 
 
 class BasicContextualSourceFactory(
-    zc.sourcefactory.factories.ContextualSourceFactory,
-    zc.sourcefactory.policies.BasicContextualSourcePolicy):
+        zc.sourcefactory.factories.ContextualSourceFactory,
+        zc.sourcefactory.policies.BasicContextualSourcePolicy):
     """Abstract base implementation for a basic contextual source factory."""

src/zc/sourcefactory/interfaces.py

@@ -20,6 +20,7 @@
 import zope.interface
 import zope.schema.interfaces
 
+
 class ISourceFactory(zope.interface.Interface):
 
     def __call__():
@@ -133,10 +134,11 @@ def filterValue(context, value):
 
 # Standard combined policies
 
+
 class ISourcePolicy(ITokenPolicy, ITermPolicy, IValuePolicy):
     pass
 
 
 class IContextualSourcePolicy(
-    ITokenPolicy, IContextualTermPolicy, IContextualValuePolicy):
+        ITokenPolicy, IContextualTermPolicy, IContextualValuePolicy):
     pass

src/zc/sourcefactory/policies.py

@@ -26,11 +26,12 @@
 try:
     unicode
 except NameError:
-    # Py3: Define unicode
+    # PY3: Define unicode
     unicode = str
 
 # Term policies
 
+
 @zope.interface.implementer(zc.sourcefactory.interfaces.ITermPolicy)
 class BasicTermPolicy(object):
     """A basic term policy.
@@ -54,7 +55,8 @@ def getTitle(self, value):
         if md:
             title = md.title
         else:
-            title = value.decode() if isinstance(value, bytes) else unicode(value)
+            title = value.decode() if isinstance(value,
+                                                 bytes) else unicode(value)
         return title
 
 
@@ -156,8 +158,9 @@ class BasicValuePolicy(object):
     def filterValue(self, value):
         return True
 
+
 @zope.interface.implementer(
-        zc.sourcefactory.interfaces.IContextualValuePolicy)
+    zc.sourcefactory.interfaces.IContextualValuePolicy)
 class BasicContextualValuePolicy(BasicValuePolicy):
     """An abstract basic value policy.
 
@@ -177,7 +180,9 @@ class BasicSourcePolicy(BasicValuePolicy, BasicTokenPolicy, BasicTermPolicy):
 
 
 class BasicContextualSourcePolicy(
-    BasicContextualValuePolicy, BasicContextualTokenPolicy, BasicContextualTermPolicy):
+        BasicContextualValuePolicy,
+        BasicContextualTokenPolicy,
+        BasicContextualTermPolicy):
     pass
 
 

src/zc/sourcefactory/tests.py

@@ -46,7 +46,8 @@
     # Python 3 adds module name to exceptions.
     (re.compile("zope.security.interfaces.ForbiddenAttribute"),
      r"ForbiddenAttribute"),
-    ])
+])
+
 
 class ConnectionStub(object):
 
@@ -56,7 +57,7 @@ def __call__(self, obj):
         return self
 
     def add(self, obj):
-        self._id +=1
+        self._id += 1
         obj._p_oid = ZODB.utils.p64(self._id)
 
 
@@ -67,18 +68,20 @@ def setUp(test):
         ConnectionStub(), (IFolder,), ZODB.interfaces.IConnection)
     test.globs['rootFolder'] = folder.rootFolder()
 
+
 def tearDown(test):
     testing.tearDown(test)
 
+
 def test_suite():
     return unittest.TestSuite((
-            doctest.DocFileSuite(
-                'README.txt'),
-            doctest.DocFileSuite(
-                'mapping.txt'),
-            doctest.DocFileSuite(
-                'constructors.txt'),
-            doctest.DocFileSuite(
-                'adapters.txt', setUp=setUp, tearDown=tearDown,
-                optionflags=doctest.ELLIPSIS),
-            ))
+        doctest.DocFileSuite(
+            'README.txt'),
+        doctest.DocFileSuite(
+            'mapping.txt'),
+        doctest.DocFileSuite(
+            'constructors.txt'),
+        doctest.DocFileSuite(
+            'adapters.txt', setUp=setUp, tearDown=tearDown,
+            optionflags=doctest.ELLIPSIS),
+    ))