Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.6 and 3.7. #2

Merged
merged 8 commits into from
Nov 7, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
language: python
python:
- 2.7
- 3.3
- 3.4
- 3.5
- 3.6
matrix:
Expand Down
6 changes: 3 additions & 3 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
include *.rst
include *.txt
include .coveragerc
include buildout.cfg
include tox.ini

recursive-include src *

global-exclude *.pyc
recursive-include src *.txt
recursive-include src *.zcml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ def read_file(*args):
extras_require={
'test': [
'zope.component[zcml]',
'persistent >= 4.4.3',
'zope.site',
'zope.testing',
'zope.testrunner',
Expand Down
4 changes: 2 additions & 2 deletions src/zc/sourcefactory/browser/token.txt
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ If an object has no parent, we fail:
>>> zc.sourcefactory.browser.token.fromPersistent(p2)
Traceback (most recent call last):
...
ValueError: Can not determine OID for <PersistentDummy object at 0x...>
ValueError: Can not determine OID for <builtins.PersistentDummy object at 0x...>

Security proxied objects are unwrapped to get to their oid or connection
attribute:
Expand All @@ -69,7 +69,7 @@ attribute:
>>> p3p._p_jar
Traceback (most recent call last):
...
ForbiddenAttribute: ('_p_jar', <PersistentDummy object at 0x...>)
ForbiddenAttribute: ('_p_jar', <builtins.PersistentDummy object at 0x...>)

>>> zc.sourcefactory.browser.token.fromPersistent(p3p)
u'0x02'
Expand Down