Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config with pure python #7

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Config with pure python #7

merged 5 commits into from
Feb 10, 2021

Conversation

icemac
Copy link
Member

@icemac icemac commented Jan 27, 2021

  • Lint the code.
  • Add support for Python 3.8 and 3.9.

Michael Howitz added 2 commits January 27, 2021 16:30
Configuring for pure-python
ec4edb0
Lint the code.
969e22a 
Add support for Python 3.8 and 3.9.
sallner
sallner requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@sallner sallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefere, if all adapts and implements are removed from the code base of this package. Maybe we can also delete the buildout.cfg here as the [py] section does not seem to important to me.

src/zc/sourcefactory/browser/mapping.py Outdated Show resolved Hide resolved
src/zc/sourcefactory/policies.py Outdated Show resolved Hide resolved
@icemac icemac requested a review from sallner February 2, 2021 13:08
sallner
sallner approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@sallner sallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes.

@icemac icemac merged commit 2aedfc3 into master Feb 10, 2021
@icemac icemac deleted the config-with-pure-python branch February 10, 2021 14:54
@icemac
Copy link
Member Author

icemac commented Feb 10, 2021

Thank you for reviewing this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sallner sallner sallner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icemac @sallner