Skip to content

Commit

Permalink
refactoring: use reverse kw argument instead of multiplier, for bette…
Browse files Browse the repository at this point in the history
…r readability
  • Loading branch information
Daniel Havlik committed Dec 5, 2019
1 parent db60f10 commit 342278d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/zc/table/column.py
Expand Up @@ -63,7 +63,7 @@ def __init__(self, title=None, name=None, subsort=False):
self.subsort = subsort
super(SortingColumn, self).__init__(title, name)

def _sort(self, items, formatter, start, stop, sorters, multiplier):
def _sort(self, items, formatter, start, stop, sorters, reverse=False):
if self.subsort and sorters:
items = sorters[0](items, formatter, start, stop, sorters[1:])
else:
Expand All @@ -72,15 +72,15 @@ def _sort(self, items, formatter, start, stop, sorters, multiplier):

items.sort(
key=lambda item: getSortKey(item, formatter),
reverse=(multiplier == -1))
reverse=reverse)

return items

def sort(self, items, formatter, start, stop, sorters):
return self._sort(items, formatter, start, stop, sorters, 1)
return self._sort(items, formatter, start, stop, sorters)

def reversesort(self, items, formatter, start, stop, sorters):
return self._sort(items, formatter, start, stop, sorters, -1)
return self._sort(items, formatter, start, stop, sorters, reverse=True)

# this is a convenience to override if you just want to keep the basic
# implementation but change the comparison values.
Expand Down

0 comments on commit 342278d

Please sign in to comment.